Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/
-----------------------------------------------------------

(Updated Sept. 3, 2013, 8:18 a.m.)


Review request for KDE Frameworks.


Changes
-------

implemented approach of defining the events - structs copied from xkb.h as found in 3rdparty copy of qtbase. Note that this doesn't matter for copyright as xcb event structures are auto-generated from xml description.


Summary (updated)
-----------------

Native event filter porting for KModifierKeyInfoProvider


Description (updated)
-------

Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.


Diffs (updated)
-----

  CMakeLists.txt 48f607b 
  staging/kguiaddons/CMakeLists.txt c2e5735 
  staging/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
  staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
  staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 

Diff: http://git.reviewboard.kde.org/r/112443/diff/


Testing (updated)
-------

used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/d3be870e/attachment-0001.html>