Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112455/#review39214
-----------------------------------------------------------


In all cases, why not just check the return value from exec(), rather than checking error() after the fact?


kfile/kdiroperator.cpp
<http://git.reviewboard.kde.org/r/112455/#comment28916>

    remove empty line



kfile/kdiroperator.cpp
<http://git.reviewboard.kde.org/r/112455/#comment28917>

    why did you change this branch at all? What's the problem with writeOk = job->exec()?



kfile/kfileplacesmodel.cpp
<http://git.reviewboard.kde.org/r/112455/#comment28920>

    missing if() around exec?


- David Faure


On Sept. 2, 2013, 4:35 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112455/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 4:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Ported all remaining usages of KIO::NetAccess to Job+exec.
> 
> In one case I have added a new method in the Private because the code looked better.
> 
> 
> Diffs
> -----
> 
>   kfile/kdiroperator.cpp 72789ae 
>   kfile/kdirselectdialog.cpp 92cff2f 
>   kfile/kfileplacesmodel.cpp e854059 
>   kfile/kfilewidget.cpp f668039 
>   kfile/knewfilemenu.cpp 5e768b8 
> 
> Diff: http://git.reviewboard.kde.org/r/112455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/05b1709b/attachment.html>