Review Request 112463: Port SMB kioslave to KF5/Qt5
Mark Gaiser
markg85 at gmail.com
Mon Sep 2 19:17:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39205
-----------------------------------------------------------
kioslave/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112463/#comment28914>
This will obviously go once i commit.
- Mark Gaiser
On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2013, 7:16 p.m.)
>
>
> Review request for KDE Runtime and KDE Frameworks.
>
>
> Description
> -------
>
> This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x
>
> Once i know that this is actually working then i will comment some qDebug lines.
>
>
> Diffs
> -----
>
> kioslave/CMakeLists.txt ff66ab6
> kioslave/smb/CMakeLists.txt a3a2265
> kioslave/smb/kio_smb.h 55efb44
> kioslave/smb/kio_smb.cpp 2c2523a
> kioslave/smb/kio_smb_auth.cpp 4d236b4
> kioslave/smb/kio_smb_browse.cpp fec6449
> kioslave/smb/kio_smb_config.cpp 81ce29c
> kioslave/smb/kio_smb_dir.cpp 5573266
> kioslave/smb/kio_smb_file.cpp 827a519
> kioslave/smb/kio_smb_internal.h b895b81
> kioslave/smb/kio_smb_internal.cpp 3c35583
> kioslave/smb/kio_smb_mount.cpp a5a7e8e
>
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
>
>
> Testing
> -------
>
> It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.
>
>
> Thanks,
>
> Mark Gaiser
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/5eb0582c/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list