Review Request 112457: Start cleanup of KDocTools

Aleix Pol Gonzalez aleixpol at kde.org
Mon Sep 2 16:42:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112457/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Start using DocBook*cmake modules from ECM (pending to be solved).
Properly construct strings for KDocTools, making sure QStringLiteral & friends are used.


Diffs
-----

  staging/kdoctools/config-kdoctools.h.cmake f2fe22c 
  staging/kdoctools/src/CMakeLists.txt de82d4d 
  staging/kdoctools/src/docbookl10nhelper.cpp abd980c 
  staging/kdoctools/src/meinproc.cpp 1c72881 
  staging/kdoctools/src/meinproc_common.cpp 18f7346 
  staging/kdoctools/src/meinproc_simple.cpp ad34fb9 
  staging/kdoctools/src/xslt.cpp 2256bf6 

Diff: http://git.reviewboard.kde.org/r/112457/diff/


Testing
-------

Builds, KDocTools has no tests.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/0436051f/attachment.html>


More information about the Kde-frameworks-devel mailing list