Review Request 112007: Use KDE configured shortcuts for Qt default key bindings
Commit Hook
null at kde.org
Mon Sep 2 15:45:45 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112007/
-----------------------------------------------------------
(Updated Sept. 2, 2013, 3:45 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Description
-------
Use KDE configured shortcuts for Qt default key bindings
Upgrade our QPlatformTheme to return the keybindings.
If the shortcut exists in KStandardShortcuts and can be configured use that;
otherwise use the default from Qt.
----
Relies on
https://codereview.qt-project.org/#change,62059
A spreadsheet of the bindings between QKeySequence -> KStandardShortcut is here:
http://static.davidedmundson.co.uk/key_bindings.csv
I think some may be valid candidates for later adding to KStandardShortcut, in particular Add Tab.
Not sure on the others. Not everything in QKeySequence::StandardKeys needs to be configurable IMHO.
Diffs
-----
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h edac8dba066b6d9981a6bc509b07e1ecdf0dd516
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp d46b5c850d3c6027e592ad0cc17f4449c4fc1e31
Diff: http://git.reviewboard.kde.org/r/112007/diff/
Testing
-------
None.
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130902/bca01c65/attachment.html>
More information about the Kde-frameworks-devel
mailing list