Review Request 112418: replace KSharedPtr with QExplicitlySharedDataPointer

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112418/#review39073
-----------------------------------------------------------


This review has been submitted with commit 1b1a51b3ffcd1fa782f1b871e47ca41662bc6b2b by Alex Richardson to branch frameworks.

- Commit Hook


On Aug. 31, 2013, 7:11 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112418/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 7:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> replace KSharedPtr with QExplicitlySharedDataPointer
> 
> 
> Diffs
> -----
> 
>   dnssd/avahi-servicebrowser.cpp 38d1a0741198405df84a8dca658bb3b9b96fda00 
>   dnssd/remoteservice.h 12d7e5d589ac79a9431290633a47bc67e974d83c 
>   dnssd/servicebase.h 6ae9d20e23baa747e6f9def8d01e474df08822da 
>   kded/kbuildservicefactory.cpp a19ad9d7e33d78a76a21671f2a73373eb2b89b13 
>   kded/kbuildservicegroupfactory.cpp 035d3fa131e9be1fc34ec24fc1d6ee3f7d85ffa6 
>   kded/kbuildservicetypefactory.cpp 28637ad4ca70496c65b77d341d1bd297e1327c3a 
>   kded/kbuildsycoca.cpp 6e456ec4a2ff3c5ca426edee18e075e9ac33b4f6 
>   kded/vfolder_menu.cpp 5f7878781f1fb972a4d30b43545c093a21b82d77 
>   kio/tests/ksycocatest.cpp c066b81fd35d3bc481a191cc22ebc9160846e3e8 
>   kparts/tests/openorsavequestion_unittest.cpp ce97a39be9574258a151335abe0cb282cd30a2b5 
>   kross/core/object.h 455525557532fd2adfe9b9b13646f026a956629d 
>   kutils/kcmoduleinfo.h 742719846ee959a2443e20e3450564e2a7c92df1 
>   kutils/kpluginselector.cpp 5f68aec3a25b8752261ab3edce1c383f427dc271 
>   kutils/ksettings/dialog.cpp 4a48b8e37c495808856ea4ec6808e4233f95427b 
>   staging/kde4support/autotests/kmimetypetest.cpp 2626b62dd0524c19f9e991052e14fd0ebdec7cc8 
>   staging/kde4support/src/kdecore/kmimetype.h 0e9fbaaefb1c8a7a92ac7f9896d75ee532e8d7d5 
>   staging/kde4support/src/kdecore/kmimetype.cpp d397ba8b233e7da9be381820e8c2eeb4b02f4c83 
>   staging/kde4support/src/kio/kdatatool.cpp b1ad8857ad4440d4610e87c8b6f903d2609c53ae 
>   staging/kio/src/core/kmountpoint.h 406a252e622d6c51c4f87a37f3ac2359ace7a696 
>   staging/kio/src/widgets/kfileitemactions.cpp d64bf6567ddef0a004f3eb57089dd3c219a430d8 
>   staging/kio/src/widgets/kopenwithdialog.cpp ca90b5ac1a5a644e0a5cae1b1847a49a4fd9b7bf 
>   staging/kio/src/widgets/krun.cpp 80ed1a6b42f9eff5cd2e87d2d831ede3a252e565 
>   staging/kservice/autotests/kservicetest.cpp b4e37abfc076297efde3737209bd816ad666413c 
>   staging/kservice/autotests/ksycocadicttest.cpp 6a265705ad79ad08240c2bb51da0c0a8d4d38ecb 
>   staging/kservice/src/services/kmimetypefactory.h 6cbc0213b954b8a286e59c0aeb425855b04a79a7 
>   staging/kservice/src/services/kmimetypefactory.cpp 1cd1ef07663082a724750cf2c65467235b59eddb 
>   staging/kservice/src/services/kservice.h 55fa2faa2970d8f0e12f8499f172e412c8c74b97 
>   staging/kservice/src/services/kservicefactory.cpp 599a261e90a9cc9e221ce0c88c53c5a6e979cd35 
>   staging/kservice/src/services/kservicegroup.h 89e5ed579c72f2b67e1d492c45acbfb9fc9e86b0 
>   staging/kservice/src/services/kservicegroup.cpp 1b5ab7b4226c148a687e07bb3af3d6de3ac68261 
>   staging/kservice/src/services/kservicegroup_p.h 5f2149798ef139be6d10ae262d2c819720ab4ccf 
>   staging/kservice/src/services/kservicetype.h 2b588ac3f82ff974501217e7223815776c664976 
>   staging/kservice/src/services/kservicetypefactory.cpp fccb43f372c25e3bb704aeccf5f084c4b6ae388b 
>   staging/kservice/src/services/kservicetypeprofile.cpp 5643558a07a0a15f4a9256d34e2413d81a4e4ae6 
>   staging/kservice/src/services/ktraderparse.cpp 940580bccd46b180cf6504401376a522f4ca0676 
>   staging/kservice/src/services/ktraderparsetree_p.h ad6066ae7441a50cc2ec9cd95810333537b45fbc 
>   staging/kservice/src/sycoca/ksycocadict.cpp 0599c6ca4934d21ce6a6bcf605063e1719a775c8 
>   staging/kservice/src/sycoca/ksycocaentry.h a7b2702afe04520bd5035fc69bb95fe8f3269387 
>   staging/kunitconversion/src/kunitconversion/converter.cpp a433240e97910da19af328727c39a20ce296cb94 
>   staging/kunitconversion/src/kunitconversion/unit.h 731c77baf9c3e73f422b65b3e3003a38efa7e572 
>   tier1/kconfig/src/core/kconfig.cpp d44c1d21807c1a3e62c4b7410ddd4232cbb828b7 
>   tier1/kconfig/src/core/kconfig_p.h 29ec44e3b4c87e48fc6072426c7398fb275115a8 
>   tier1/kconfig/src/core/kconfigbackend.h 738cd27998a15cc459b0c252442e8fbfd7c5b4de 
>   tier1/kconfig/src/core/kconfigbackend.cpp c25671ace96b4102115cf2244c5dd79317ff57b9 
> 
> Diff: http://git.reviewboard.kde.org/r/112418/diff/
> 
> 
> Testing
> -------
> 
> compiles and tests pass
> 
> I guess KSharedPtr can be moved to kde4support after this commit
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130901/7a60b52f/attachment.html>