Review Request 113507: Use ecm_mark_as_test for test-only targets

David Faure faure at kde.org
Thu Oct 31 11:55:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113507/#review42738
-----------------------------------------------------------

Ship it!


Looks good.

- David Faure


On Oct. 30, 2013, 3:59 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113507/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Use ecm_mark_as_test for test-only targets
> 
> 
> Diffs
> -----
> 
>   kio/httpfilter/autotests/CMakeLists.txt 2ae8fddf795bb14ca99be1734dada330bcf2c58a 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt d929b28dca8755613ba1cd071e400aeff7c1ea8c 
>   kioslave/http/tests/CMakeLists.txt 294c42ae6f5eb7af56c888d120ba804c0e3b36f2 
>   tier1/karchive/autotests/CMakeLists.txt af6e8b3a438590fe933d538200cebca056086da2 
>   tier1/kdbusaddons/tests/CMakeLists.txt 65a65bfce32976d79f0234a0181b0fe9cbb7357f 
>   tier1/kjs/autotests/CMakeLists.txt 7ea499439cf9fe32180baf9a89f33517ea806d95 
>   tier2/kauth/autotests/CMakeLists.txt 90e6d77be3d71827b4ac13b89fb39212e3db1d39 
>   tier3/kbookmarks/autotests/CMakeLists.txt c0a67db787db3f426d172270d00a0d3f08554575 
>   tier3/kservice/autotests/CMakeLists.txt c656d441dc641dea5106ba725bdb34af940af33f 
>   tier3/xmlgui/tests/krichtexteditor/CMakeLists.txt 308c28f5ec2d59c63f08401b3ffb42c28f74829f 
>   tier4/kde4support/autotests/CMakeLists.txt a850e8db69871e61a0699a8807c84adc18303a25 
> 
> Diff: http://git.reviewboard.kde.org/r/113507/diff/
> 
> 
> Testing
> -------
> 
> compiles + installs
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131031/a9d57886/attachment.html>


More information about the Kde-frameworks-devel mailing list