Review Request 113505: Add unit tests for KTranscript

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113505/#review42710
-----------------------------------------------------------

Ship it!


Most definitely. The test semantics looks good. I'll see to factor out the
plugin search code later.


- Chusslove Illich


On Oct. 30, 2013, 4:11 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113505/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> I wrote those tests when I was still considering porting KTranscript to QJS. While this did not happen, I think there is still value in getting those tests in.
> 
> 
> Diffs
> -----
> 
>   tier2/ki18n/autotests/CMakeLists.txt 49f46a1 
>   tier2/ki18n/autotests/ktranscripttest.h PRE-CREATION 
>   tier2/ki18n/autotests/ktranscripttest.cpp PRE-CREATION 
>   tier2/ki18n/autotests/test.js PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113505/diff/
> 
> 
> Testing
> -------
> 
> New tests pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131030/eece14d9/attachment-0001.html>