Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

Alexander Neundorf neundorf at kde.org
Tue Oct 29 17:36:03 UTC 2013


On Tuesday 29 October 2013, Stephen Kelly wrote:
> Kevin Ottens wrote:
> > Ship it!
> > 
> > 
> > Looks fine to me and is aligned with prior discussions.
> 
> Note that it is named ECM_foo, but it contains hardcoded KDE icon theme
> names.

Good point.
As it is, IMO for being "ECM", it needs way more documentation.
It needs to be documented so that it can be used by people who know nothing 
about KDE or KDE's icon scheme.

Or should that be in the framework which deals with icon loading ?

Alex


More information about the Kde-frameworks-devel mailing list