Review Request 113436: Deprecate KEmoticonsTheme methods

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113436/#review42585
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Oct. 25, 2013, 8:39 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113436/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 8:39 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Deprecate KEmoticonsTheme methods
> 
> Before the initial cleanup, the loadTheme(), removeEmoticon() and addEmoticon
> methods of KEmoticonsTheme called the KEmoticonsProvider methods of the
> same name, which were either empty or useless.
> 
> Now the KEmoticonsProvider methods are pure virtual and therefore those
> KEmoticonsTheme methods are deprecated and a subclassing of
> KEmoticonsProvider is advised.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 
>   staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c 
>   staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 
> 
> Diff: http://git.reviewboard.kde.org/r/113436/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131029/1e36f413/attachment.html>