Review Request 113479: fix kshareddatacache on windows

Sune Vuorela kde at pusling.com
Mon Oct 28 20:08:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113479/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 8:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, kdelibs and Michael Pyne.


Repository: kdelibs


Description
-------

fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.

Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.


Diffs
-----

  tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31 
  tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d 

Diff: http://git.reviewboard.kde.org/r/113479/diff/


Testing
-------

Test suite passes


Thanks,

Sune Vuorela

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131028/21078e05/attachment.html>


More information about the Kde-frameworks-devel mailing list