Review Request 113432: Install FindDBusMenuQt5.cmake

[Aurélien Gâteau]

> On Oct. 25, 2013, 5:40 p.m., Stephen Kelly wrote:
> > Why does that library not install a Config.cmake file?

Sebas put together a patch to do so, but it needs to be refined because it currently does not work for Qt4 (dbusmenu-qt is Qt4 and Qt5). Furthermore, the upstream project needs to accept it, which is not guaranteed. Installing this Find module fixes the issue, potentially faster and without breaking working Qt4 setup.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113432/#review42361
-----------------------------------------------------------


On Oct. 25, 2013, 5:16 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113432/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 5:16 p.m.)
> 
> 
> Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Install FindDBusMenuQt5.cmake. This makes it possible to fix issues in kde-workspace and to remove kdelibs/tier2/knotifications/cmake
> 
> 
> Diffs
> -----
> 
>   find-modules/FindDBusMenuQt5.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113432/diff/
> 
> 
> Testing
> -------
> 
> Module installs successfully, kde-workspace can use it after adaptation.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131025/ab95228d/attachment.html>