Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()
Alex Merry
kde at randomguy3.me.uk
Thu Oct 24 21:29:36 UTC 2013
> On Oct. 24, 2013, 7:25 p.m., Alex Merry wrote:
> > whoami is part of coreutils, so should be available everywhere. The only possible issue I see is that we've gone from a test that doesn't depend on PATH to one that does. This isn't necessarily a problem, but it will test slightly different code paths.
>
> Nicolás Alvarez wrote:
> "part of coreutils" is irrelevant for Windows, there's no such thing as coreutils. The point is that Windows also happens to have a command called 'whoami'.
Ah, sorry, by "everywhere", I meant "all UNIX systems". My point was merely that no GNU-based UNIX system, at least, will be missing whoami. This is less obvious for whoami than for ls (at least for me; I had to check with my package manager). It is also part of the BSD general commands, so should exist on all BSD flavours, including OSX.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113424/#review42320
-----------------------------------------------------------
On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113424/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 3:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()
>
> Unlike "/bin/ls" this also works on Windows
>
>
> Diffs
> -----
>
> tier1/kconfig/autotests/kdesktopfiletest.cpp 8f2ed2047e39f4f6b5d24a620474c3894f7986cc
>
> Diff: http://git.reviewboard.kde.org/r/113424/diff/
>
>
> Testing
> -------
>
> Test passes on both linux and windows
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131024/77853013/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list