Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113422/#review42297
-----------------------------------------------------------



tier1/kconfig/autotests/kconfignokdehometest.cpp
<http://git.reviewboard.kde.org/r/113422/#comment30774>

    Please review what you changed.
    
    You're removing the config directory of the test user, sounds dangerous!
    
    Note that it was changing the value of the XDG_CONFIG_HOME before running the test.
    
    I'm unsure what's the proper cross-platform fix to it.


- Aleix Pol Gonzalez


On Oct. 24, 2013, 3:55 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113422/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 3:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Port kconfigtest and kconfignokdehometest to QStandardPaths
> 
> They relied on setting XDG_CONFIG_HOME which will not work on Windows
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/kconfigtest.h e0d7f7350159187e7611ddefd99d7d6faabde6ac 
>   tier1/kconfig/autotests/kconfignokdehometest.cpp ce53ca58fc7e1ce5a4345cce8a17de0e05866019 
>   tier1/kconfig/autotests/kconfigtest.cpp 26e6a781bedf226ef0ca0d9030e107d3c412bd35 
> 
> Diff: http://git.reviewboard.kde.org/r/113422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131024/bda37865/attachment.html>