Review Request 113370: move KDED to Tier3

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113370/#review42261
-----------------------------------------------------------



kded/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113370/#comment30755>

    "should be replaced with"? it already is



kded/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113370/#comment30756>

    Why not use the version number of *this* framework? The same risks for discrepancies exist whichever framework is used for the version checking.



kioslave/http/kcookiejar/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113370/#comment30758>

    ok, we'll have to change that, obviously.
    
    kded should install that xml file, and kcookiejar should use the installed xml file (or the one from tier3/kded when building kdelibs all-in-one)


- David Faure


On Oct. 21, 2013, 3:56 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113370/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Moves KDED to tier3.
> 
> I have removed any use of X11/Properties used to communicate with KSplash since we want to use either DBus or Wayland but certainly not X11.
> 
> I plan to work on session startup in a few weeks so I will fix (if nobody else does before me) KSplash <---> KDED communication by then.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4ea56ae 
>   kded/CMakeLists.txt a06ed09 
>   kded/DESIGN  
>   kded/HOWTO  
>   kded/Info.plist.template  
>   kded/Mainpage.dox  
>   kded/README.kded  
>   kded/config-kded.h.cmake 21210ab 
>   kded/kded.h  
>   kded/kded.cpp aab548b 
>   kded/kdedadaptor.h  
>   kded/kdedadaptor.cpp  
>   kded/kdedmodule.desktop  
>   kded/org.kde.kded5.service.in  
>   kioslave/http/kcookiejar/CMakeLists.txt 8d61c01 
>   tier3/CMakeLists.txt eed8acb 
> 
> Diff: http://git.reviewboard.kde.org/r/113370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131024/9a9f1c6f/attachment.html>