Review Request 113247: Port KCompletion away from KStandardAction

[David Edmundson]

> On Oct. 15, 2013, 1:40 p.m., Kevin Ottens wrote:
> > tier2/kcompletion/src/klineedit.cpp, line 1174
> > <http://git.reviewboard.kde.org/r/113247/diff/1/?file=201273#file201273line1174>
> >
> >     Couldn't it use QKeySequence::DeleteCompleteLine instead? or is KStandardShortcut::Clear different?

They are _currently_ different.

The original Qt code hard control+U hardcoded, now it's a qkeysequence but it's not bound to the KStandardShortcut in our KDE PlatformTheme.
The default KDE shortcut for clear is empty. I think it makes sense to fix this.

I've made the change you suggested to QKeySequence. This action is only in the menu so it's only for displaying the shortcut not actually handling anything.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113247/#review41775
-----------------------------------------------------------


On Oct. 14, 2013, 5:04 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113247/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 5:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Fix depends in KCompletion
> 
> KCompletion cannot use KStandardAction which is from kconfigwidgets in tier3
> 
> 
> Diffs
> -----
> 
>   tier2/kcompletion/CMakeLists.txt 8c34bd6 
>   tier2/kcompletion/KCompletionConfig.cmake.in 46647d1 
>   tier2/kcompletion/src/CMakeLists.txt d2b7602 
>   tier2/kcompletion/src/klineedit.cpp 2f70935 
> 
> Diff: http://git.reviewboard.kde.org/r/113247/diff/
> 
> 
> Testing
> -------
> 
> Compiled in source
> Tried compiling standalone (it builds, but has a linker fail on something unrelated)
> Ran klineedittest and checked combobox was the same.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131023/919827f3/attachment.html>