Review Request 113376: KDirWatch: don't check for symlinks on Windows.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113376/#review42172
-----------------------------------------------------------

Ship it!


Inspecting the code, you don't seem to have changed the logic on Unix systems, so it looks good to me.

- Alex Merry


On Oct. 21, 2013, 11:46 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113376/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 11:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KDirWatch: don't check for symlinks on Windows.
> 
> Windows doesn't have symbolic links, at least not in the same way as Unix,
> so it doesn't have functions like lstat.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 
> 
> Diff: http://git.reviewboard.kde.org/r/113376/diff/
> 
> 
> Testing
> -------
> 
> KDirWatch tests still pass on Linux.
> 
> Still doesn't compile on Windows, but getting closer.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131022/c64ffc16/attachment.html>