Review Request 113373: Enable C++11 support by default.

Stephen Kelly steveire at gmail.com
Mon Oct 21 19:18:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113373/#review42126
-----------------------------------------------------------


As the next CMake release will have a better solution which works for all compilers:

 set(CMAKE_CXX_STANDARD 11)

I'm not in favor of adding and having to support this flag.

I don't consider it my decision though.

- Stephen Kelly


On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113373/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 6:51 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Enable C++11 support by default.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d 
> 
> Diff: http://git.reviewboard.kde.org/r/113373/diff/
> 
> 
> Testing
> -------
> 
> Compiles, all required fixes have been integrated into the frameworks branch by now (at least for the subset I have the required dependencies for).
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131021/2700c661/attachment.html>


More information about the Kde-frameworks-devel mailing list