Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

Kevin Ottens ervin at kde.org
Mon Oct 21 11:30:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113297/#review42076
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Oct. 17, 2013, 12:08 a.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113297/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 12:08 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Remove 'override' from ThreadWeaver::IdDecorator destructor.
> 
> MSVC2010 apparently doesn't support 'override' on destructors,
> even though it's legal according to C++11.
> 
> 
> Diffs
> -----
> 
>   tier1/threadweaver/src/Weaver/IdDecorator.h 648d4236cc22015a1d145892daf368084a199053 
> 
> Diff: http://git.reviewboard.kde.org/r/113297/diff/
> 
> 
> Testing
> -------
> 
> Still builds on Linux, now builds on Windows too.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131021/a0d55b6d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list