Review Request 113328: Fix standalone build of kdoctools
Aurélien Gâteau
agateau at kde.org
Fri Oct 18 15:33:01 UTC 2013
> On Oct. 18, 2013, 5:23 p.m., Aleix Pol Gonzalez wrote:
> > tier2/kdoctools/CMakeLists.txt, line 30
> > <http://git.reviewboard.kde.org/r/113328/diff/1/?file=203382#file203382line30>
> >
> > The KF5 find_package should be outside of the if
Oh right, should update the template as well then.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review41951
-----------------------------------------------------------
On Oct. 18, 2013, 2:14 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 2:14 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
>
>
> Diffs
> -----
>
> tier2/kdoctools/src/CMakeLists.txt 8b726a8
> tier2/kdoctools/CMakeLists.txt 53fd0e9
> superbuild/CMakeLists.txt 5cdec94
>
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
>
>
> Testing
> -------
>
> Builds within kdelibs and using superbuild.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131018/7302e6ce/attachment.html>
More information about the Kde-frameworks-devel
mailing list