Review Request 113248: Cleanup KNotifyConfig

[Aurélien Gâteau]

> On Oct. 15, 2013, 3:51 p.m., Aurélien Gâteau wrote:
> > Standalone build fails here with this message:
> > 
> > -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version "5.0.0", minimum required is "5.0.0") found components:  CMake Compiler InstallDirs 
> > CMake Error at CMakeLists.txt:19 (find_package):
> >   Found package configuration file:
> > 
> >     /home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake
> > 
> >   but it set KIO_FOUND to FALSE so package "KIO" is considered to be NOT
> >   FOUND.  Reason given by package:
> > 
> >   The following imported targets are referenced, but are missing:
> >   KF5::KBookmarks KF5::XmlGui KF5::Solid
> >
> 
> Aleix Pol Gonzalez wrote:
>     Is it really a problem in KNotifyConfig? I'd say it is in KIO...

Indeed, you are probably right.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113248/#review41778
-----------------------------------------------------------


On Oct. 14, 2013, 7:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113248/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 7:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly.
> 
> 
> Diffs
> -----
> 
>   staging/knotifyconfig/CMakeLists.txt 65867ba 
>   staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 
>   staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 
>   staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 
> 
> Diff: http://git.reviewboard.kde.org/r/113248/diff/
> 
> 
> Testing
> -------
> 
> builds, teh test seems to work still.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131018/3a2076eb/attachment.html>