Review Request 113298: KDirWatch code style: cleanup whitespace.

[Nicolás Alvarez]

> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote:
> > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225
> > <http://git.reviewboard.kde.org/r/113298/diff/3/?file=202348#file202348line1225>
> >
> >     I think this could be better as uncommenting the variable and using Q_UNUSED (and moving the * to the right too), but that's minor

Sure, I can do that.


> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote:
> > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199
> > <http://git.reviewboard.kde.org/r/113298/diff/3/?file=202349#file202349line199>
> >
> >     why did you choose "_path" instead of just "path"?

Because that's what the definition has in the .cpp:
KDirWatchPrivate::Entry* KDirWatchPrivate::entry(const QString &_path)

I could change them all to path, I don't know why it has an underscore. But that's for a separate commit.


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/#review41907
-----------------------------------------------------------


On Oct. 17, 2013, 4:05 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113298/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KDirWatch code style: cleanup whitespace.
> 
> The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and alignment, including a few tabs(!). This is a full cleanup of it.
> 
> I appreciate any feedback; if I "fixed" something that didn't need fixing, or if you see more whitespace errors that I didn't fix, or if I should push this to master too, or if I should leave the damn thing alone and discard the review :)
> 
> This file is also lacking braces for single-line conditionals and loops; I'll fix that in a separate commit for easier reviewing. It's also mixing 2-space and 4-space indentations, but changing everything to 4 spaces (as the kdelibs coding style says) seemed too intrusive. Perhaps I should change the few 4-space indentations into 2-space for consistency?
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d 
>   tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a 
>   tier1/kcoreaddons/src/lib/io/kdirwatch.h 7f6ca8ce83426c81a6336514c247aa9d115ec59e 
> 
> Diff: http://git.reviewboard.kde.org/r/113298/diff/
> 
> 
> Testing
> -------
> 
> Still compiles :)
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131017/99f36bf9/attachment-0001.html>