Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem
Aurélien Gâteau
agateau at kde.org
Thu Oct 17 10:04:58 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113276/
-----------------------------------------------------------
(Updated Oct. 17, 2013, 12:04 p.m.)
Review request for KDE Frameworks and Stephen Kelly.
Changes
-------
template/CMakeLists.txt: Define KF5_VERSION before using it
Repository: kdelibs
Description
-------
Calls to functions provided by includes must come after includes themselves.
This request also includes a separate commit for template/CMakeLists.txt, which moves all calls to find_package() after ecm is setup and provide a hint as to where find_package() calls should be. This should hopefully help prevent future errors.
Diffs (updated)
-----
template/CMakeLists.txt 96a5363
tier1/kidletime/CMakeLists.txt 21e9f37
tier1/kjs/CMakeLists.txt 9c2acaa
tier1/kwindowsystem/CMakeLists.txt e4f984b
Diff: http://git.reviewboard.kde.org/r/113276/diff/
Testing
-------
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131017/c6961df3/attachment.html>
More information about the Kde-frameworks-devel
mailing list