Review Request 113300: Improve porting to Qt/KF5 scripts
Sebastian Kügler
sebas at kde.org
Thu Oct 17 10:03:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113300/#review41874
-----------------------------------------------------------
Ship it!
Looks good. Feel free to push your changes to these scripts right away.
As to moving to kdesdk: Rather not, they're really my quick-and-dirty toolbox, I don't want anyone else who doesn't know what they're doing to use them. Once we've finished porting, we can just delete them. For now they can be useful to take away some of the monkey replace-edit cycles.
- Sebastian Kügler
On Oct. 17, 2013, 5:01 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113300/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 5:01 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Improve the porting scripts in plasma-framework (maybe they should be in kdesdk?).
> - Add a script to remove the Qt module part of an include (<QtGui/QLabel> becomes <QLabel>).
> - Add more cases when porting cmake files, adding the Qt libraries as well.
>
>
> Diffs
> -----
>
> tools/port-cmake.sh 832cdd2
> tools/port-includes.sh PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113300/diff/
>
>
> Testing
> -------
>
> Been trying to port an application, to see how it worked.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131017/cd20e865/attachment.html>
More information about the Kde-frameworks-devel
mailing list