Review Request 113256: KMessageBox: Remove last traces of notification support

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113256/#review41777
-----------------------------------------------------------


Just occurred to me that it might not be the right course of action after all... It's likely that we want to deal with this KNotification dependency from KMessageBox in the same way than we do for its KConfig dependency using an interface which is reimplemented in the integration framework.

Could you look in that direction instead? You can poke me on IRC if you need guidance.

Sorry about the rework.

- Kevin Ottens


On Oct. 15, 2013, 1:26 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113256/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 1:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KMessageBox: Remove last traces of notification support
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html acb408c 
>   tier1/kwidgetsaddons/src/kmessagebox.h 9a76c23 
>   tier1/kwidgetsaddons/src/kmessagebox.cpp b2345d0 
> 
> Diff: http://git.reviewboard.kde.org/r/113256/diff/
> 
> 
> Testing
> -------
> 
> Builds with and without -DKDE_NO_DEPRECATED. KMessageBox tests pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131015/a1a066d6/attachment.html>