Review Request 113248: Cleanup KNotifyConfig

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113248/#review41776
-----------------------------------------------------------



staging/knotifyconfig/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113248/#comment30504>

    Shouldn't this type of conditional removed now that we use alias targets? Or you plan to change that in another commit?


- Kevin Ottens


On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113248/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 5:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly.
> 
> 
> Diffs
> -----
> 
>   staging/knotifyconfig/CMakeLists.txt 65867ba 
>   staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 
>   staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 
>   staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 
> 
> Diff: http://git.reviewboard.kde.org/r/113248/diff/
> 
> 
> Testing
> -------
> 
> builds, teh test seems to work still.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131015/d5d52308/attachment.html>