Review Request 113226: Cleanup kdirwatch includes.

[Nicolás Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113226/
-----------------------------------------------------------

(Updated Oct. 14, 2013, 4:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Cleanup kdirwatch includes.

* kdirwatch_p.h is including inotify.h, but it doesn't use any inotify
  types or macros. The types are only used in kdirwatch.cpp, so I moved
  the inotify includes there.
* kdirwatch.cpp includes sys/ioctl.h and sys/utsname.h. These headers
  are not available in Windows, and they are only needed if inotify is
  present. Thus, include them in the #if HAVE_SYS_INOTIFY_H block.


Diffs
-----

  tier1/kcoreaddons/src/lib/io/kdirwatch.cpp a56801a67fd787d879ac6b300f80a20a5d054bbe 
  tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 3858bfaa68967d29327ca4319ab164af511d3186 

Diff: http://git.reviewboard.kde.org/r/113226/diff/


Testing
-------

Compiles and tests pass on Linux.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131014/8e7e1f57/attachment-0001.html>