Review Request 113148: Move and clean KBuildsycoca to KService

[Àlex Fiestas]

> On Oct. 12, 2013, 4:57 p.m., David Faure wrote:
> > kded/kbuildsycoca.cpp, line 84
> > <http://git.reviewboard.kde.org/r/113148/diff/3/?file=200224#file200224line84>
> >
> >     Not called anymore with your commit.
> >     
> >     But I'm not sure we want to remove the feature... what's the problem with keeping the kcrash dependency?

I don't have an opinion on this, if you want to keep it then we can keep it.

I removed it because it looked like we wanted to do it but we couldn't because of abi/api/behavior compatibility, now it is the time to break things so I removed it :p

For what is worth I think that we could replace some of KSCrash functionality with systemd-coredump but I don't know exactly how either of them work so...


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41603
-----------------------------------------------------------


On Oct. 10, 2013, 10:04 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 10:04 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified them for reviewboard.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131014/d10fd4aa/attachment.html>