Review Request 113240: Move KJsEmbed to tier3

Àlex Fiestas afiestas at kde.org
Mon Oct 14 15:40:37 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113240/#review41735
-----------------------------------------------------------

Ship it!


Looks good, it compiles and all policies are done so good to go.

- Àlex Fiestas


On Oct. 14, 2013, 2:04 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113240/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> It does the move, not much else going on.
> 
> 
> Diffs
> -----
> 
>   staging/CMakeLists.txt a3bfaab 
>   staging/kjsembed/AUTHORS  
>   staging/kjsembed/CMakeLists.txt  
>   staging/kjsembed/KJsEmbedConfig.cmake.in  
>   staging/kjsembed/Mainpage.dox  
>   staging/kjsembed/examples/calc/calc.js  
>   staging/kjsembed/examples/calc/calc.ui  
>   staging/kjsembed/examples/console/console.js  
>   staging/kjsembed/examples/console/console.ui  
>   staging/kjsembed/examples/docviewer/docviewer.js  
>   staging/kjsembed/examples/docviewer/docviewer.ui  
>   staging/kjsembed/examples/fancy/fancy.js  
>   staging/kjsembed/examples/grammar/grammar.js  
>   staging/kjsembed/examples/kjsconsole/CMakeLists.txt  
>   staging/kjsembed/examples/kjsconsole/console.h  
>   staging/kjsembed/examples/kjsconsole/console.cpp  
>   staging/kjsembed/examples/kjsconsole/console.qrc  
>   staging/kjsembed/examples/kjsconsole/images/bug.png  
>   staging/kjsembed/examples/kjsconsole/images/class.png  
>   staging/kjsembed/examples/kjsconsole/images/constant.png  
>   staging/kjsembed/examples/kjsconsole/images/method.png  
>   staging/kjsembed/examples/kjsconsole/images/next.png  
>   staging/kjsembed/examples/kjsconsole/images/no.png  
>   staging/kjsembed/examples/kjsconsole/images/property.png  
>   staging/kjsembed/examples/kjsconsole/images/runto.png  
>   staging/kjsembed/examples/kjsconsole/images/start.png  
>   staging/kjsembed/examples/kjsconsole/images/step.png  
>   staging/kjsembed/examples/kjsconsole/images/stop.png  
>   staging/kjsembed/examples/kjsconsole/jsconsole.ui  
>   staging/kjsembed/examples/kjsconsole/kjs_object_model.h  
>   staging/kjsembed/examples/kjsconsole/kjs_object_model.cpp  
>   staging/kjsembed/examples/kjsconsole/main.cpp  
>   staging/kjsembed/examples/kjsconsole/numberedtextview.h  
>   staging/kjsembed/examples/kjsconsole/numberedtextview.cpp  
>   staging/kjsembed/examples/scribble/scribble.js  
>   staging/kjsembed/examples/tests/args.js  
>   staging/kjsembed/examples/tests/brush.js  
>   staging/kjsembed/examples/tests/builtins.js  
>   staging/kjsembed/examples/tests/class.js  
>   staging/kjsembed/examples/tests/colortest.js  
>   staging/kjsembed/examples/tests/conio.js  
>   staging/kjsembed/examples/tests/domtest.js  
>   staging/kjsembed/examples/tests/events.js  
>   staging/kjsembed/examples/tests/fileio.js  
>   staging/kjsembed/examples/tests/fonttest.js  
>   staging/kjsembed/examples/tests/frame.js  
>   staging/kjsembed/examples/tests/gc.js  
>   staging/kjsembed/examples/tests/include.js  
>   staging/kjsembed/examples/tests/inner.js  
>   staging/kjsembed/examples/tests/jsslot.js  
>   staging/kjsembed/examples/tests/layout.js  
>   staging/kjsembed/examples/tests/library.js  
>   staging/kjsembed/examples/tests/listproperties.js  
>   staging/kjsembed/examples/tests/matt.js  
>   staging/kjsembed/examples/tests/paintertest.js  
>   staging/kjsembed/examples/tests/paintevent.js  
>   staging/kjsembed/examples/tests/pixmap.js  
>   staging/kjsembed/examples/tests/recttest.js  
>   staging/kjsembed/examples/tests/settings.js  
>   staging/kjsembed/examples/tests/signslots.js  
>   staging/kjsembed/examples/tests/statictest.js  
>   staging/kjsembed/examples/tests/stylesheet.js  
>   staging/kjsembed/examples/tests/svgtest.js  
>   staging/kjsembed/examples/tests/system.js  
>   staging/kjsembed/examples/tests/test.svg  
>   staging/kjsembed/examples/tests/test.ui  
>   staging/kjsembed/examples/tests/typecheck.js  
>   staging/kjsembed/examples/tests/uitest.js  
>   staging/kjsembed/examples/tests/uitest2.js  
>   staging/kjsembed/examples/tests/url.js  
>   staging/kjsembed/examples/tests/widgettest.js  
>   staging/kjsembed/src/CMakeLists.txt  
>   staging/kjsembed/src/kjscmd/CMakeLists.txt  
>   staging/kjsembed/src/kjscmd/console.js  
>   staging/kjsembed/src/kjscmd/kjscmd.cpp  
>   staging/kjsembed/src/kjscmd/kjscmd.qrc  
>   staging/kjsembed/src/kjsembed/CMakeLists.txt  
>   staging/kjsembed/src/kjsembed/QBrush_bind.h  
>   staging/kjsembed/src/kjsembed/QBrush_bind.cpp  
>   staging/kjsembed/src/kjsembed/application.h  
>   staging/kjsembed/src/kjsembed/application.cpp  
>   staging/kjsembed/src/kjsembed/binding_support.h  
>   staging/kjsembed/src/kjsembed/binding_support.cpp  
>   staging/kjsembed/src/kjsembed/brush.h  
>   staging/kjsembed/src/kjsembed/brush.cpp  
>   staging/kjsembed/src/kjsembed/builtins.h  
>   staging/kjsembed/src/kjsembed/builtins.cpp  
>   staging/kjsembed/src/kjsembed/color.h  
>   staging/kjsembed/src/kjsembed/color.cpp  
>   staging/kjsembed/src/kjsembed/dom.h  
>   staging/kjsembed/src/kjsembed/dom.cpp  
>   staging/kjsembed/src/kjsembed/eventproxy.h  
>   staging/kjsembed/src/kjsembed/eventproxy.cpp  
>   staging/kjsembed/src/kjsembed/filedialog_binding.h  
>   staging/kjsembed/src/kjsembed/filedialog_binding.cpp  
>   staging/kjsembed/src/kjsembed/fileio.h  
>   staging/kjsembed/src/kjsembed/fileio.cpp  
>   staging/kjsembed/src/kjsembed/font.h  
>   staging/kjsembed/src/kjsembed/font.cpp  
>   staging/kjsembed/src/kjsembed/image.h  
>   staging/kjsembed/src/kjsembed/image.cpp  
>   staging/kjsembed/src/kjsembed/iosupport.h  
>   staging/kjsembed/src/kjsembed/iosupport.cpp  
>   staging/kjsembed/src/kjsembed/jseventmapper.h  
>   staging/kjsembed/src/kjsembed/jseventmapper.cpp  
>   staging/kjsembed/src/kjsembed/jseventutils.h  
>   staging/kjsembed/src/kjsembed/jseventutils.cpp  
>   staging/kjsembed/src/kjsembed/kjseglobal.h  
>   staging/kjsembed/src/kjsembed/kjseglobal.cpp  
>   staging/kjsembed/src/kjsembed/kjsembed.h  
>   staging/kjsembed/src/kjsembed/kjsembed.cpp  
>   staging/kjsembed/src/kjsembed/object_binding.h  
>   staging/kjsembed/src/kjsembed/object_binding.cpp  
>   staging/kjsembed/src/kjsembed/pen.h  
>   staging/kjsembed/src/kjsembed/pen.cpp  
>   staging/kjsembed/src/kjsembed/pixmap.h  
>   staging/kjsembed/src/kjsembed/pixmap.cpp  
>   staging/kjsembed/src/kjsembed/point.h  
>   staging/kjsembed/src/kjsembed/point.cpp  
>   staging/kjsembed/src/kjsembed/pointer.h  
>   staging/kjsembed/src/kjsembed/qaction_binding.h  
>   staging/kjsembed/src/kjsembed/qaction_binding.cpp  
>   staging/kjsembed/src/kjsembed/qformbuilder_binding.h  
>   staging/kjsembed/src/kjsembed/qformbuilder_binding.cpp  
>   staging/kjsembed/src/kjsembed/qlayout_binding.h  
>   staging/kjsembed/src/kjsembed/qlayout_binding.cpp  
>   staging/kjsembed/src/kjsembed/qobject_binding.h  
>   staging/kjsembed/src/kjsembed/qobject_binding.cpp  
>   staging/kjsembed/src/kjsembed/qpainter_binding.h  
>   staging/kjsembed/src/kjsembed/qpainter_binding.cpp  
>   staging/kjsembed/src/kjsembed/quiloader_binding.h  
>   staging/kjsembed/src/kjsembed/quiloader_binding.cpp  
>   staging/kjsembed/src/kjsembed/qwidget_binding.h  
>   staging/kjsembed/src/kjsembed/qwidget_binding.cpp  
>   staging/kjsembed/src/kjsembed/rect.h  
>   staging/kjsembed/src/kjsembed/rect.cpp  
>   staging/kjsembed/src/kjsembed/settings.h  
>   staging/kjsembed/src/kjsembed/settings.cpp  
>   staging/kjsembed/src/kjsembed/size.h  
>   staging/kjsembed/src/kjsembed/size.cpp  
>   staging/kjsembed/src/kjsembed/slotproxy.h  
>   staging/kjsembed/src/kjsembed/slotproxy.cpp  
>   staging/kjsembed/src/kjsembed/static_binding.h  
>   staging/kjsembed/src/kjsembed/static_binding.cpp  
>   staging/kjsembed/src/kjsembed/svg_binding.h  
>   staging/kjsembed/src/kjsembed/svg_binding.cpp  
>   staging/kjsembed/src/kjsembed/test/QByteArray_bind.h  
>   staging/kjsembed/src/kjsembed/test/QByteArray_bind.cpp  
>   staging/kjsembed/src/kjsembed/url.h  
>   staging/kjsembed/src/kjsembed/url.cpp  
>   staging/kjsembed/src/kjsembed/util.h  
>   staging/kjsembed/src/kjsembed/value_binding.h  
>   staging/kjsembed/src/kjsembed/value_binding.cpp  
>   staging/kjsembed/src/kjsembed/variant_binding.h  
>   staging/kjsembed/src/kjsembed/variant_binding.cpp  
>   tier3/CMakeLists.txt 4f5c1c8 
> 
> Diff: http://git.reviewboard.kde.org/r/113240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131014/555638de/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list