Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113196/#review41623
-----------------------------------------------------------


This review has been submitted with commit 9c3a5107f7939b7b6fbbfdb41090ff5d5fab5ead by Nicolás Alvarez to branch frameworks.

- Commit Hook


On Oct. 11, 2013, 5:25 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113196/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2013, 5:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kdirwatch: include correct header for time_t and ino_t.
> 
> We were including sys/time.h and sys/param.h, but Windows doesn't have
> them, and POSIX says those types are defined in sys/types.h.
> 
> This doesn't fix the build on Windows, but it's a step.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7 
> 
> Diff: http://git.reviewboard.kde.org/r/113196/diff/
> 
> 
> Testing
> -------
> 
> Still builds and passes tests on Linux/gcc.
> 
> Still fails to build on Windows/MSVC2010 but not for this reason :)
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131013/5ee155ae/attachment.html>