Review Request 112730: add CMake changes to knewstuff

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/#review41599
-----------------------------------------------------------

Ship it!


minor things found, but don't let that stop you


knewstuff/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112730/#comment30398>

    can be removed, after linking to KIOCore (see below)



knewstuff/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112730/#comment30397>

    (I'm curious why this is necessary)



knewstuff/KNewStuffConfig.cmake.in
<http://git.reviewboard.kde.org/r/112730/#comment30396>

    why is kjs listed as a dependency here but not in the cmakelists.txt?



knewstuff/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112730/#comment30394>

    should be KIOCore now.



knewstuff/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112730/#comment30395>

    just KArchive, for consistency


- David Faure


On Oct. 9, 2013, 8:24 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112730/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 8:24 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Chusslove Illich.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This makes it so I can mkdir build; cd build; cmake ../; make install from knewstuff sources.
> It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio libraries have been split out apparently.
> I'm not sure why sources had to be changed, but I had to add includes of klocalizedstring where we didn't need them before somehow.
> 
> 
> Diffs
> -----
> 
>   knewstuff/CMakeLists.txt 8ee3653c92692d606a2ff6d1fa69d0d8deb5439a 
>   knewstuff/KNewStuffConfig.cmake.in PRE-CREATION 
>   knewstuff/src/CMakeLists.txt 5bdf0f6ee619751d66ec48dc7516a73cfe89a8c0 
>   knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa 
>   knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 
>   knewstuff/src/ui/entrydetailsdialog.cpp 65b75d79941d9026f368f82c7b6df91d754e0925 
>   knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 
> 
> Diff: http://git.reviewboard.kde.org/r/112730/diff/
> 
> 
> Testing
> -------
> 
> It builds and installs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131012/def94b59/attachment-0001.html>