[extra-cmake-modules] find-modules: Remove the check for the LIBRARIES variable.

Stephen Kelly steveire at gmail.com
Sat Oct 12 12:26:38 UTC 2013


Git commit b6ddac117f6e0d3e4a88ddaf8fbb769756f367ca by Stephen Kelly.
Committed on 12/10/2013 at 12:24.
Pushed by skelly into branch 'master'.

Remove the check for the LIBRARIES variable.

It is redundant and obsolete.

Some frameworks can have erroneous values (eg KConfigWidgets currently
sets FooBar_LIBRARIES). Downstreams are expected to use the imported
target name instead.

CCMAIL: kde-frameworks-devel at kde.org

M  +0    -3    find-modules/FindKF5.cmake

http://commits.kde.org/extra-cmake-modules/b6ddac117f6e0d3e4a88ddaf8fbb769756f367ca

diff --git a/find-modules/FindKF5.cmake b/find-modules/FindKF5.cmake
index 5c987dd..0841c97 100644
--- a/find-modules/FindKF5.cmake
+++ b/find-modules/FindKF5.cmake
@@ -171,9 +171,6 @@ macro(_KF5_HANDLE_COMPONENT _comp)
    if(NOT KF5_FIND_QUIETLY)
       message(STATUS "KF5[${_comp}]: Loaded ${${_comp}_CONFIG}")
    endif()
-   if(NOT DEFINED ${_comp}_LIBRARIES)
-      message(FATAL_ERROR "${_comp} does not set ${_comp}_LIBRARIES !")
-   endif()
    set(KF5_INCLUDE_DIRS ${KF5_INCLUDE_DIRS} ${${_comp}_INCLUDE_DIRS} )
    set(KF5_LIBRARIES ${KF5_LIBRARIES} ${${_comp}_LIBRARIES} )
 endmacro()


More information about the Kde-frameworks-devel mailing list