Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113158/#review41578
-----------------------------------------------------------


You should import the test app into kio/tests (and possibly mention it here in a comment)


staging/kjobwidgets/src/kdialogjobuidelegate.cpp
<http://git.reviewboard.kde.org/r/113158/#comment30383>

    It should be created on demand.
    
    (add a getter here that creates it if still null)


- David Faure


On Oct. 7, 2013, 6:28 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113158/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 6:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Instead of implementing queueing in KDialogJobUiDelegate, I'm making use of QErrorMessage which has queueing built into it. We also inherit the "Show this message again" checkbox, but I have a review request here https://codereview.qt-project.org/67243 that adds new API to Qt 5.3 , so we can hide that once 5.3 comes out ( if that makes sense ).
> 
> 
> Diffs
> -----
> 
>   staging/kjobwidgets/src/kdialogjobuidelegate.h 5d17a4d 
>   staging/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae 
> 
> Diff: http://git.reviewboard.kde.org/r/113158/diff/
> 
> 
> Testing
> -------
> 
> Tested by writing a application that uses KIO to fetch an invalid site url. Dialog pops up just fine.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131012/ccd0aeef/attachment.html>