Review Request 113182: Remove all the versioned classes of KCategoryDrawer.
David Faure
faure at kde.org
Sat Oct 12 08:41:08 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/#review41574
-----------------------------------------------------------
Ship it!
tier1/itemviews/src/kcategorydrawer.h
<http://git.reviewboard.kde.org/r/113182/#comment30380>
+docu + @since 5.0
tier1/itemviews/src/kcategorydrawer.h
<http://git.reviewboard.kde.org/r/113182/#comment30379>
This should have a DEPRECATED macro on the class itself, to trigger a compiler warning when using it.
- David Faure
On Oct. 9, 2013, 4:45 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113182/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2013, 4:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Remove all the versioned classes of KCategoryDrawer.
>
> Remove original KCategoryDrawer and KCategoryDrawerV2 which
> were already deprecated and merge everything into one class which has
> the features of KCategoryDrawerV3 called simply KCategoryDrawer.
>
> Compatability with KCategoryDrawerV3 is left and marked as deprecated.
>
>
> Diffs
> -----
>
> tier1/itemviews/src/kcategorizedview.h c8035c5
> tier1/itemviews/src/kcategorizedview.cpp 35fafae
> tier1/itemviews/src/kcategorizedview_p.h 4c175fb
> tier1/itemviews/src/kcategorydrawer.h e36197b
> tier1/itemviews/src/kcategorydrawer.cpp 0e45e23
> tier1/itemviews/tests/kcategorizedviewtest.cpp 116278c
>
> Diff: http://git.reviewboard.kde.org/r/113182/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131012/3d73c848/attachment.html>
More information about the Kde-frameworks-devel
mailing list