Review Request 113206: Make KIconLoader a bit less fragile

Aleix Pol Gonzalez aleixpol at kde.org
Fri Oct 11 18:07:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/
-----------------------------------------------------------

(Updated Oct. 11, 2013, 6:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that would delete the d-pointer.

This patch makes it so instead of deleting it, it will clear the values and initialize them again instead.


Diffs
-----

  tier3/kiconthemes/src/kiconloader.cpp bf3899a 

Diff: http://git.reviewboard.kde.org/r/113206/diff/


Testing
-------

Makes ktoolbartest pass (and valgrind-proof)


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131011/7febd771/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list