KCapacityBar's painting code
Stephen Kelly
steveire at gmail.com
Fri Oct 11 10:58:53 UTC 2013
David Faure wrote:
> Hi Stephen,
>
> The commit below removed the initialisation of d->ce_capacityBar,
> but this variable is still used in KCapacityBar::drawCapacityBar.
> Can we remove that block of code completely?
> Since the "[...]" contains the actual painting code, I assume the above
> block can be removed, but I'm confused because the commit log seems to
> contradict that. There can't be any styling in the style implementation if
> we never call the style in order to do the drawing...
I think the most likely explanation is that I misunderstood this point when
porting the class to be KDE-free. I probably thought this was related to a
style hint that a user of the class would set. If that's not the case, then
I'll defer to you on the proper fix.
Thanks,
Steve.
More information about the Kde-frameworks-devel
mailing list