Review Request 113155: Port all kde4_add_unit_test uses

Alexander Richardson arichardson.kde at googlemail.com
Thu Oct 10 19:56:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/#review41535
-----------------------------------------------------------



kfile/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113155/#comment30344>

    ecm_add_tests expects the source file to be passed (i.e. kurlnavigatortest.cpp)



kio/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113155/#comment30345>

    same here



kioslave/http/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113155/#comment30346>

    same


- Alexander Richardson


On Oct. 10, 2013, 8:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113155/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Stop using kde4_add_unit_test.
> 
> One step less towards no kde4_* uses.
> 
> 
> Diffs
> -----
> 
>   kded/tests/CMakeLists.txt ca392d2 
>   kfile/tests/CMakeLists.txt d28d642 
>   khtml/tests/CMakeLists.txt 59a0a56 
>   kio/tests/CMakeLists.txt a60eac0 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
>   kioslave/http/tests/CMakeLists.txt 000c488 
> 
> Diff: http://git.reviewboard.kde.org/r/113155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131010/d71047d2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list