Review Request 113154: Remove KFileMetaDataWidget and friends

Vishesh Handa me at vhanda.in
Thu Oct 10 12:56:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113154/
-----------------------------------------------------------

(Updated Oct. 10, 2013, 12:56 p.m.)


Review request for KDE Frameworks.


Changes
-------

Added a note in KDE5Porting.html


Repository: kdelibs


Description
-------

    Remove KFileMetaDataWidget and friends
    
    These have been deprecated in KDE4.[1] This also removes the
    KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented
    out so it doesn't really make a difference.
    
    Eventually we will need a proper plugin based system so that the
    Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog

[1] https://git.reviewboard.kde.org/r/113153/


Diffs (updated)
-----

  KDE5PORTING.html 3171afc 
  kdewidgets/kde.widgets b138d4e 
  staging/kde4support/src/CMakeLists.txt 5eb649c 
  staging/kde4support/src/kio/kcommentwidget.cpp 6223a0c 
  staging/kde4support/src/kio/kcommentwidget_p.h 7a9c710 
  staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h 52735ad 
  staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp 018d183 
  staging/kde4support/src/kio/kfilemetadataprovider.cpp 59cb238 
  staging/kde4support/src/kio/kfilemetadataprovider_p.h 0969f53 
  staging/kde4support/src/kio/kfilemetadatareader.cpp 6a7909c 
  staging/kde4support/src/kio/kfilemetadatareader_p.h af054c2 
  staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp 0d2b993 
  staging/kde4support/src/kio/kfilemetadatawidget.h 31dd3c7 
  staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df2312 
  staging/kde4support/src/kio/kmetaprops.h b03dd4c 
  staging/kde4support/src/kio/kmetaprops.cpp 46624c5 
  staging/kde4support/src/kio/knfotranslator.cpp 0494679 
  staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 
  staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 

Diff: http://git.reviewboard.kde.org/r/113154/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131010/92baaa58/attachment.html>


More information about the Kde-frameworks-devel mailing list