Review Request 112932: Update superbuild to include all tiered libraries
Alexander Neundorf
neundorf at kde.org
Wed Oct 9 17:24:20 UTC 2013
On Wednesday 09 October 2013, Kevin Ottens wrote:
> > On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote:
> > > Looks good to me, not adding the shipit because I'm clueless about
> > > superbuild.
> > >
> > > Why do we need to specify the dependencies from superbuild? Shouldn't
> > > they depend on the Config.cmake files?
> >
> > Alexander Neundorf wrote:
> > You mean after "DEPENDS" ?
> > Because the superbuild CMakeLists.txt has no information otherwise
> > which sub-builds depend on which other sub-builds, so this
> > information must be there to make sure e.g. tier1 libs are built
> > before tier2 libs etc.
>
> It looks fine to me too... but I'm rather clueless about superbuild.
> Alexander any chance you could take a look and push ship it if you see no
> problem with that one?
I don't maintain it anymore, so I don't "ship it", but I also don't object.
Alex
More information about the Kde-frameworks-devel
mailing list