Review Request 112913: Move KModifierKeyInfo from GuiAddons to KWindowSystem

[Kevin Ottens]

> On Sept. 29, 2013, 4:38 p.m., David Faure wrote:
> > -1, see https://git.reviewboard.kde.org/r/112443/

Well... See Nicolas comment there, even the API is tied to the way X works.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112913/#review41004
-----------------------------------------------------------


On Sept. 24, 2013, 8:15 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112913/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 8:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> As discussed in https://git.reviewboard.kde.org/r/112443/
> 
> It's quite windowing system specific and only implemented for X11 so
> it makes more sense in the framework which is about the windowing
> system specific code.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
>   tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 
>   tier1/kguiaddons/tests/kmodifierkeyinfotest.cpp 39984a0 
>   tier1/kwindowsystem/src/CMakeLists.txt 31fb53e 
>   tier1/kwindowsystem/src/kmodifierkeyinfo.h PRE-CREATION 
>   tier1/kwindowsystem/src/kmodifierkeyinfo.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kmodifierkeyinfoprovider.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kmodifierkeyinfoprovider_dummy.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kmodifierkeyinfoprovider_p.h PRE-CREATION 
>   tier1/kwindowsystem/src/kmodifierkeyinfoprovider_x11.cpp PRE-CREATION 
>   tier1/kwindowsystem/tests/CMakeLists.txt 5cf5868 
>   tier1/kwindowsystem/tests/kmodifierkeyinfotest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112913/diff/
> 
> 
> Testing
> -------
> 
> compiled
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131009/c2d96700/attachment.html>