Review Request 113077: Get Kross ready for tier3

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113077/
-----------------------------------------------------------

(Updated Oct. 8, 2013, 7:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

This patch makes kross ready for moving to tier3. The changes were done in a separate branch (which I can push if required). The git log looks like this -

783b0a3 Kross: Remove module name from the header includes
8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
6c62ace Kross: Add feature_summary
d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
2c627df Kross: Add CMake stuff along with KrossConfig.cmake
a28624b Kross: Follow frameworks directory scheme
741b86c KRoss: Camel case the library names

Kross does not have any unit tests, and some of its normal tests seem to be segfaulting as well. I'm not sure what to do about that. Also when Kross is being split, its other plugins will needs to be added as well. Kdelibs only contains the kjs and QtScript plugins.

And finally, the QtScript plugin has a test - Should that be moved to the tests folder?


Diffs
-----

  kross/CMakeLists.txt 3424cb8 
  kross/KrossConfig.cmake.in PRE-CREATION 
  kross/console/CMakeLists.txt da73a6f 
  kross/console/main.cpp  
  kross/core/CMakeLists.txt 5a8b845 
  kross/core/action.h 3f4d985 
  kross/core/action.cpp 5c6ee2c 
  kross/core/actioncollection.h 9e90df6 
  kross/core/actioncollection.cpp 89d8282 
  kross/core/childreninterface.h 0b11b2e 
  kross/core/errorinterface.h bb23235 
  kross/core/interpreter.h 95293e4 
  kross/core/interpreter.cpp  
  kross/core/krossconfig.h 481c4b6 
  kross/core/krossconfig.cpp  
  kross/core/manager.h aefdf87 
  kross/core/manager.cpp e0dddf1 
  kross/core/metafunction.h 1413289 
  kross/core/metatype.h 08f7c6c 
  kross/core/object.h 6f2b6a4 
  kross/core/object.cpp  
  kross/core/script.h 1701883 
  kross/core/script.cpp  
  kross/core/wrapperinterface.h  
  kross/kjs/CMakeLists.txt 94af9ae 
  kross/kjs/kjsinterpreter.h  
  kross/kjs/kjsinterpreter.cpp  
  kross/kjs/kjsscript.h  
  kross/kjs/kjsscript.cpp  
  kross/modules/CMakeLists.txt 7391bb0 
  kross/modules/form.h 2da62c7 
  kross/modules/form.cpp 862b71b 
  kross/modules/translation.h  
  kross/modules/translation.cpp  
  kross/qts/CMakeLists.txt b85c1c7 
  kross/qts/interpreter.h  
  kross/qts/interpreter.cpp  
  kross/qts/main.cpp  
  kross/qts/plugin.h  
  kross/qts/plugin.cpp  
  kross/qts/script.h  
  kross/qts/script.cpp  
  kross/qts/test.es  
  kross/qts/values_p.h  
  kross/src/CMakeLists.txt PRE-CREATION 
  kross/src/modules/CMakeLists.txt PRE-CREATION 
  kross/test/CMakeLists.txt c931ec4 
  kross/test/main.cpp da926fb 
  kross/test/profile.py  
  kross/test/testguiform.py  
  kross/test/testguiform.rb  
  kross/test/testguiform.ui  
  kross/test/testguiqt.py  
  kross/test/testguiqt.rb  
  kross/test/testguitk.py  
  kross/test/testkross.js  
  kross/test/testkross.py  
  kross/test/testobject.h 5383073 
  kross/test/testobject.cpp 560d88c 
  kross/test/unittest.es  
  kross/test/unittest.js  
  kross/test/unittest.py  
  kross/test/unittest.rb  
  kross/ui/CMakeLists.txt 14ba2d8 
  kross/ui/model.h 314ff24 
  kross/ui/model.cpp 4849149 
  kross/ui/plugin.h  
  kross/ui/plugin.cpp  
  kross/ui/view.h 4241aad 
  kross/ui/view.cpp  

Diff: http://git.reviewboard.kde.org/r/113077/diff/


Testing
-------

Some tests segfault. Some of them run. I should probably convert them into autotests.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131008/f530071f/attachment-0001.html>