Review Request 113076: kcookiejar: Fix parsing of weird dates

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/
-----------------------------------------------------------

(Updated Oct. 7, 2013, 2:47 p.m.)


Review request for KDE Frameworks and John Layt.


Changes
-------

Simplified the code: reading the RFC shows there is no need to handle timezones.

See http://tools.ietf.org/html/rfc2616#section-3.3.1

Relevant quote:

All HTTP date/time stamps MUST be represented in Greenwich Mean Time
   (GMT), without exception. For the purposes of HTTP, GMT is exactly
   equal to UTC (Coordinated Universal Time). This is indicated in the
   first two formats by the inclusion of "GMT" as the three-letter
   abbreviation for time zone, and MUST be assumed when reading the
   asctime format. HTTP-date is case sensitive and MUST NOT include
   additional LWS beyond that specifically included as SP in the
   grammar.

       HTTP-date    = rfc1123-date | rfc850-date | asctime-date
       rfc1123-date = wkday "," SP date1 SP time SP "GMT"
       rfc850-date  = weekday "," SP date2 SP time SP "GMT"
       asctime-date = wkday SP date3 SP time SP 4DIGIT


Repository: kdelibs


Description
-------

This fixes kcookiejartest, which was failing to parse the date from the Y2K38 check.

The test started failing on build.kde.org when the Qt version here was switched to the "stable" branch, which seems to parse things differently than the version of Qt build.kde.org used to run.

The code was ported from KDateTime::fromString() to QDateTime::fromString(), whose syntax for date formatting is different, but the format was not updated.

This patch is incomplete, see the FIXME comments in removeTimeZone(). But I want to ensure this is the correct way to go before getting into timezones.


Diffs (updated)
-----

  kioslave/http/kcookiejar/kcookiejar.cpp e943da9 

Diff: http://git.reviewboard.kde.org/r/113076/diff/


Testing
-------

kcookiejartest now passes again (must be run with LANG=C btw)


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131007/62ec5917/attachment.html>