Review Request 113076: kcookiejar: Fix parsing of weird dates

[Aurélien Gâteau]

> On Oct. 5, 2013, 10:53 a.m., David Faure wrote:
> > Good catch about the format string syntax changes between kde and qt.
> > 
> > But why not just add "t" to the format string to include the timezone, as it used to do with %Z, instead of the removeTimeZone() function?
> >

As far as I can tell, "t" is not supported in QDateTime format string. There is however the, new in 5.2, QTimeZone class. I am going to rework the patch to use it instead of ignoring the time zone information.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/#review41267
-----------------------------------------------------------


On Oct. 3, 2013, 6 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113076/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 6 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This fixes kcookiejartest, which was failing to parse the date from the Y2K38 check.
> 
> The test started failing on build.kde.org when the Qt version here was switched to the "stable" branch, which seems to parse things differently than the version of Qt build.kde.org used to run.
> 
> The code was ported from KDateTime::fromString() to QDateTime::fromString(), whose syntax for date formatting is different, but the format was not updated.
> 
> This patch is incomplete, see the FIXME comments in removeTimeZone(). But I want to ensure this is the correct way to go before getting into timezones.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/kcookiejar/kcookiejar.cpp e943da9 
> 
> Diff: http://git.reviewboard.kde.org/r/113076/diff/
> 
> 
> Testing
> -------
> 
> kcookiejartest now passes again (must be run with LANG=C btw)
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131007/a8ec5acc/attachment-0001.html>