Review Request 112985: Adjust API in KEmoticons framework: map and index methods

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112985/
-----------------------------------------------------------

(Updated Oct. 6, 2013, 9:02 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add @since 5.0 in the new methods.


Repository: kdelibs


Description
-------

Adjust API in KEmoticons framework: map and index methods

-Make map and index KEmoticons API slightly clearer and deprecate
the methods that are confusing.
-Use the new methods in the plugins.


Diffs (updated)
-----

  staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 
  staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 

Diff: http://git.reviewboard.kde.org/r/112985/diff/


Testing
-------

It builds. It installs. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131006/8204a3ac/attachment.html>