Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Oct 5 01:42:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/#review41263
-----------------------------------------------------------


Thanks - it appears to fix the kbookmark build - I'm getting the same klocale issues as well.

You can add the group konsole or me to any Konsole patches.

- Kurt Hindenburg


On Oct. 4, 2013, 2:35 p.m., Casian Andrei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113091/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Build fails following some changes in kdelibs.
> 
> Quick fix!
> 
> 
> Diffs
> -----
> 
>   src/BookmarkHandler.h 04e988d 
>   src/BookmarkHandler.cpp 7a54b17 
> 
> Diff: http://git.reviewboard.kde.org/r/113091/diff/
> 
> 
> Testing
> -------
> 
> Not tested, because of some link issue with Ki18n...
> 
> Should work though.
> 
> 
> Thanks,
> 
> Casian Andrei
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131005/a27fb8ce/attachment.html>


More information about the Kde-frameworks-devel mailing list