Review Request 113045: Prepare KCMUtils for move to tier3

[David Edmundson]

> On Oct. 4, 2013, 7 a.m., David Faure wrote:
> > Looks good, but why don't we replace KCategoryDrawer with KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones?
> > It should be SC since v3 derives from v2 derives from v1.

It's not entirely source compatible since the constructor changes and v1 needs deleting manually. 
Will be easy to change now that everything in kdelibs uses V3 style. Will make a new review today.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41196
-----------------------------------------------------------


On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113045/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 8:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Only find publicly used libraries in cmake.in
> 
> 
> KCategoryDrawer -> KCategoryDrawerV3
> 
> 
> No QString cast from ascii
> 
> 
> Diffs
> -----
> 
>   staging/kcmutils/CMakeLists.txt dc577d3 
>   staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 
>   staging/kcmutils/src/CMakeLists.txt dc19649 
>   staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 
>   staging/kcmutils/src/kcmoduleinfo.cpp f46308c 
>   staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab 
>   staging/kcmutils/src/kcmultidialog.cpp 4812407 
>   staging/kcmutils/src/kpluginselector.cpp 77cbfda 
>   staging/kcmutils/src/kpluginselector_p.h 2dffae0 
>   staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a 
>   staging/kcmutils/src/ksettings/dialog.cpp 131f75f 
>   staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc 
>   staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 
> 
> Diff: http://git.reviewboard.kde.org/r/113045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131004/f9f96c98/attachment-0001.html>