Review Request 113088: Prepare kpty for moving

Aleix Pol Gonzalez aleixpol at kde.org
Thu Oct 3 23:11:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41193
-----------------------------------------------------------



kpty/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113088/#comment30225>

    Rename to the camel-cased version.



kpty/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113088/#comment30223>

    shouldn't it be KPty? The classes are called KPty at least.



kpty/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113088/#comment30224>

    You can remove this


- Aleix Pol Gonzalez


On Oct. 3, 2013, 10:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 10:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -----
> 
>   kpty/CMakeLists.txt ecc296c120a6a7938a703773a63af2534b445897 
>   kpty/ConfigureChecks.cmake  
>   kpty/KPTYConfig.cmake.in PRE-CREATION 
>   kpty/config-pty.h.cmake  
>   kpty/kgrantpty.c  
>   kpty/kpty.h  
>   kpty/kpty.cpp  
>   kpty/kpty_p.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptyprocess.cpp  
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/tests/CMakeLists.txt 1f39830df5e7eacf3b64ea456c1892c62e53fde5 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> -------
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/352ae1bf/attachment.html>


More information about the Kde-frameworks-devel mailing list