Review Request 112828: Add a new functions to add unit tests

Aleix Pol Gonzalez aleixpol at kde.org
Thu Oct 3 13:29:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review41179
-----------------------------------------------------------

Ship it!


Looks good to me

- Aleix Pol Gonzalez


On Oct. 2, 2013, 5:14 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 5:14 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddTests.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/ebff3703/attachment.html>


More information about the Kde-frameworks-devel mailing list