Review Request 113043: Codestyle changes for kdesu

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113043/#review41162
-----------------------------------------------------------



staging/kdesu/src/client.h
<http://git.reviewboard.kde.org/r/113043/#comment30202>

    Should be 
    
    KDEsuClientPrivate *const d;
    
    (No space after '*')



staging/kdesu/src/kdesu_stub.c
<http://git.reviewboard.kde.org/r/113043/#comment30203>

    `len-1` should be `len - 1`



staging/kdesu/src/kdesu_stub.c
<http://git.reviewboard.kde.org/r/113043/#comment30204>

    same



staging/kdesu/src/kdesu_stub.c
<http://git.reviewboard.kde.org/r/113043/#comment30205>

    size-2 => size - 2



staging/kdesu/src/kdesu_stub.c
<http://git.reviewboard.kde.org/r/113043/#comment30206>

    while you are at it, remove that trailing space



staging/kdesu/src/process.h
<http://git.reviewboard.kde.org/r/113043/#comment30207>

    trailingspace--



staging/kdesu/src/process.h
<http://git.reviewboard.kde.org/r/113043/#comment30208>

    PtyProcessPrivate * const d
    =>
    PtyProcessPrivate *const d



staging/kdesu/src/process.cpp
<http://git.reviewboard.kde.org/r/113043/#comment30209>

    This is going to add warnings about unused vars, either use 
    Q_UNUSED or leave the arguments commented out like this:
    
    virtual_hook(int /*id*/, void * /*data*/)
    



staging/kdesu/src/ssh.h
<http://git.reviewboard.kde.org/r/113043/#comment30210>

    SshProcessPrivate * const d;
    
    =>
    
    SshProcessPrivate *const d;



staging/kdesu/src/stub.h
<http://git.reviewboard.kde.org/r/113043/#comment30211>

    trailing spaces



staging/kdesu/src/stub.cpp
<http://git.reviewboard.kde.org/r/113043/#comment30213>

    Missing curly braces



staging/kdesu/src/su.cpp
<http://git.reviewboard.kde.org/r/113043/#comment30214>

    kdelibs coding style says `case` should not be more indented than `switch`.
    
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Switch_statements


- Aurélien Gâteau


On Oct. 3, 2013, 11:20 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113043/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 11:20 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> As discussed at the frameworks meeting, here's the codestyle change for kdesu. It follows the defined kdelibs coding style. Also removes commented qDebug code and does a micro-optimization in couple places.
> 
> With this the code is so much more readable and consistent.
> 
> 
> Diffs
> -----
> 
>   staging/kdesu/src/client.h 4ce7b3a 
>   staging/kdesu/src/client.cpp df1268e 
>   staging/kdesu/src/defaults.h 706a088 
>   staging/kdesu/src/kcookie.h f7ecca3 
>   staging/kdesu/src/kcookie.cpp 58b470a 
>   staging/kdesu/src/kdesu_stub.c 2de76d4 
>   staging/kdesu/src/process.h 8bcc655 
>   staging/kdesu/src/process.cpp 0a4dcf1 
>   staging/kdesu/src/ssh.h 5de00a6 
>   staging/kdesu/src/ssh.cpp c4586cf 
>   staging/kdesu/src/stub.h 13a5e92 
>   staging/kdesu/src/stub.cpp d827394 
>   staging/kdesu/src/su.h a7d0e99 
>   staging/kdesu/src/su.cpp 77eb071 
> 
> Diff: http://git.reviewboard.kde.org/r/113043/diff/
> 
> 
> Testing
> -------
> 
> All builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131003/a5cadda6/attachment-0001.html>