Review Request 113067: Fix compilation

David Edmundson david at davidedmundson.co.uk
Wed Oct 2 21:48:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 9:48 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Partially revert ca62212ab2a68e716167f08f2433fe735dcba302

By removing find_package(KF5 InstallDirs) ${LIB_INSTALL_DIR} does
not expand causing kdelibsLibraryTargets to be installed to try
and install to the root directory /cmake/ which causes compile errors.

We cannot remove kdelibsLibraryTargets until each library can install itself 

see http://build.kde.org/job/kdelibs_frameworks_qt5/1317/console


Diffs
-----

  CMakeLists.txt cdc3120 

Diff: http://git.reviewboard.kde.org/r/113067/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/37dc5931/attachment.html>


More information about the Kde-frameworks-devel mailing list